Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i8n: create fr_FR translation #120

Merged
merged 2 commits into from
Oct 29, 2024
Merged

i8n: create fr_FR translation #120

merged 2 commits into from
Oct 29, 2024

Conversation

MickGe
Copy link
Contributor

@MickGe MickGe commented Oct 29, 2024

Simple translation to french.

And thank you for time.

@NekoAria
Copy link
Collaborator

I've added dayjs support for French, and added a French README.

Please check the README for any errors.

Thanks for your contribution.

@MickGe
Copy link
Contributor Author

MickGe commented Oct 29, 2024

I don't notice error on README, you're very fluent in French! 😉

Sorry, I forgot dayjs

@NekoAria
Copy link
Collaborator

I don't notice error on README, you're very fluent in French! 😉

Sorry, I forgot dayjs

Haha, actually, I just used Claude AI to help translate the README—I don’t actually speak French! 🤣

As for the dayjs part, that’s not on you.
Currently, we don’t have guidelines on submitting i18n-related updates, so most people tend to only notice the JSON files in the locales directory.

@NekoAria NekoAria merged commit 696d77e into electh:main Oct 29, 2024
1 check passed
neovoe pushed a commit to neovoe/ReactFlux that referenced this pull request Nov 1, 2024
* i8n: create fr_FR translation

* feat(i18n): add French language support and README

---------

Co-authored-by: Neko Aria <990879119@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants