Add an 'X' button for clearing text in the search field. #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -122,10 +122,31 @@ header { | |||
| -moz-transition: opacity .3s ease-out, -moz-transform .3s ease-out, box-shadow .3s, width .2s ease-out; | |||
| transition: opacity .3s ease-out, transform .3s ease-out, box-shadow .3s, width .2s ease-out; | |||
| } | |||
| header #clearSearch { | |||
There was a problem hiding this comment.
CSS Code for the "X" or Clear Search button.
It had to be position: absolute due to the resizing of the search box.
|
Hi @birdwing, good work! :) I made some small enhancements and it works great! |
|
Thanks! Glad I could help! |
|
I took a look at the changes, I guess I should have noticed you had a reset function already, and i love the use of the CSS transitions instead of the :hover I was using. I really should look more into those. Awesome project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw on issue #35 you needed a way to clear the search box.
Here is a simple edit. Of the development files
unfortunately I am unable to run the bash script to minimize the css and js, but since I didn't add any files you should have no problem with it.
I hope this helps :)