Updated #421 syntax

electerious · Jan 10, 2016 · 2a0212e · 2a0212e
1 parent 68e992b
commit 2a0212e
Show file tree

Hide file tree

Showing 2 changed files with 58 additions and 53 deletions.
diff --git a/plugins/check/index.php b/plugins/check/index.php
@@ -99,43 +99,45 @@
 if ($error==='')	echo('No critical problems found. Lychee should work without problems!' . PHP_EOL);
 else				echo $error;
 
-# Don't go further if the user is not connected
-session_start();
-$isAdmin = ((isset($_SESSION['login'])&&$_SESSION['login']===true)&&
-        (isset($_SESSION['identifier'])&&$_SESSION['identifier']===$settings['identifier']));
-
-if(!$isAdmin)
-{
-        echo(PHP_EOL . PHP_EOL . 'You have to be logged in to see more information.');
-	exit();
-}
-
-
 # Show separator
 echo(PHP_EOL . PHP_EOL . 'System Information' . PHP_EOL);
 echo('------------------' . PHP_EOL);
 
-# Load json
-$json = file_get_contents(LYCHEE_SRC . 'package.json');
-$json = json_decode($json, true);
-
-# About imagick
-$imagick = extension_loaded('imagick');
-if ($imagick===true)	$imagickVersion = @Imagick::getVersion();
-else					$imagick = '-';
-if (!isset($imagickVersion, $imagickVersion['versionNumber'])||$imagickVersion==='')	$imagickVersion = '-';
-else																					$imagickVersion = $imagickVersion['versionNumber'];
-
-# Output system information
-echo('Lychee Version:  ' . $json['version'] . PHP_EOL);
-echo('DB Version:      ' . $settings['version'] . PHP_EOL);
-echo('System:          ' . PHP_OS . PHP_EOL);
-echo('PHP Version:     ' . floatval(phpversion()) . PHP_EOL);
-echo('MySQL Version:   ' . $database->server_version . PHP_EOL);
-echo('Imagick:         ' . $imagick . PHP_EOL);
-echo('Imagick Active:  ' . $settings['imagick'] . PHP_EOL);
-echo('Imagick Version: ' . $imagickVersion . PHP_EOL);
-echo('GD Version:      ' . $gdVersion['GD Version'] . PHP_EOL);
-echo('Plugins:         ' . $settings['plugins'] . PHP_EOL);
+# Ensure that user is logged in
+session_start();
+
+if ((isset($_SESSION['login'])&&$_SESSION['login']===true)&&
+	(isset($_SESSION['identifier'])&&$_SESSION['identifier']===$settings['identifier'])) {
+
+	# Load json
+	$json = file_get_contents(LYCHEE_SRC . 'package.json');
+	$json = json_decode($json, true);
+
+	# About imagick
+	$imagick = extension_loaded('imagick');
+	if ($imagick===true)	$imagickVersion = @Imagick::getVersion();
+	else					$imagick = '-';
+	if (!isset($imagickVersion, $imagickVersion['versionNumber'])||$imagickVersion==='')	$imagickVersion = '-';
+	else																					$imagickVersion = $imagickVersion['versionNumber'];
+
+	# Output system information
+	echo('Lychee Version:  ' . $json['version'] . PHP_EOL);
+	echo('DB Version:      ' . $settings['version'] . PHP_EOL);
+	echo('System:          ' . PHP_OS . PHP_EOL);
+	echo('PHP Version:     ' . floatval(phpversion()) . PHP_EOL);
+	echo('MySQL Version:   ' . $database->server_version . PHP_EOL);
+	echo('Imagick:         ' . $imagick . PHP_EOL);
+	echo('Imagick Active:  ' . $settings['imagick'] . PHP_EOL);
+	echo('Imagick Version: ' . $imagickVersion . PHP_EOL);
+	echo('GD Version:      ' . $gdVersion['GD Version'] . PHP_EOL);
+	echo('Plugins:         ' . $settings['plugins'] . PHP_EOL);
+
+} else {
+
+	# Don't go further if the user is not logged in
+	echo('You have to be logged in to see more information.');
+	exit();
+
+}
 
 ?>
diff --git a/plugins/displaylog/index.php b/plugins/displaylog/index.php
@@ -41,38 +41,41 @@
 $settings = new Settings($database);
 $settings = $settings->get();
 
-# Check if the user is connected
+# Ensure that user is logged in
 session_start();
-$isAdmin = ((isset($_SESSION['login'])&&$_SESSION['login']===true)&&
-        (isset($_SESSION['identifier'])&&$_SESSION['identifier']===$settings['identifier']));
 
-if(!$isAdmin)
-{
-        exit('You have to be logged in to see the log.');
-}
+if ((isset($_SESSION['login'])&&$_SESSION['login']===true)&&
+	(isset($_SESSION['identifier'])&&$_SESSION['identifier']===$settings['identifier'])) {
 
+	# Result
+	$query	= Database::prepare($database, "SELECT FROM_UNIXTIME(time), type, function, line, text FROM ?", array(LYCHEE_TABLE_LOG));
+	$result	= $database->query($query);
 
-# Result
-$query	= Database::prepare($database, "SELECT FROM_UNIXTIME(time), type, function, line, text FROM ?", array(LYCHEE_TABLE_LOG));
-$result	= $database->query($query);
+	# Output
+	if ($result->num_rows===0) {
 
-# Output
-if ($result->num_rows===0) {
+		echo('Everything looks fine, Lychee has not reported any problems!');
 
-	echo('Everything looks fine, Lychee has not reported any problems!' . PHP_EOL . PHP_EOL);
+	} else {
 
-} else {
+		while($row = $result->fetch_row()) {
 
-	while($row = $result->fetch_row()) {
+			# Encode result before printing
+			$row = array_map('htmlentities', $row);
 
-		# Encode result before printing
-		$row = array_map("htmlentities", $row);
+			# Format: time TZ - type - function(line) - text
+			printf ("%s - %s - %s (%s) \t- %s\n", $row[0], $row[1], $row[2], $row[3], $row[4]);
 
-		# Format: time TZ - type - function(line) - text
-		printf ("%s %s - %s - %s (%s) \t- %s\n", $row[0], date_default_timezone_get(), $row[1], $row[2], $row[3], $row[4]);
+		}
 
 	}
 
+} else {
+
+	# Don't go further if the user is not logged in
+	echo('You have to be logged in to see the log.');
+	exit();
+
 }
 
 ?>