forked from microsoft/vscode-python
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix main #7
Merged
Merged
fix main #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no change logs because this feature is not released yet. Fixes microsoft#21039
Closes microsoft#20906 --------- Co-authored-by: Courtney Webster <60238438+cwebster-99@users.noreply.github.com>
closes microsoft#20078 and closes microsoft#20085 (which is about the testing work to support this code) This logic now successfully works to discover the pytest repo tests. This branch takes into account all the previous comments made to the python discovery logic in the previous PR (located on my personal fork). Therefore this is a second round of edits on this code. It now works for the pytest library (discovers all the tests in the pytest library). --------- Co-authored-by: Brett Cannon <brcan@microsoft.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
eleanorjboyd
added a commit
that referenced
this pull request
Apr 18, 2023
eleanorjboyd
added a commit
that referenced
this pull request
Apr 18, 2023
eleanorjboyd
added a commit
that referenced
this pull request
Apr 18, 2023
eleanorjboyd
added a commit
that referenced
this pull request
Apr 18, 2023
eleanorjboyd
added a commit
that referenced
this pull request
Apr 18, 2023
eleanorjboyd
added a commit
that referenced
this pull request
Apr 19, 2023
eleanorjboyd
added a commit
that referenced
this pull request
Apr 19, 2023
eleanorjboyd
added a commit
that referenced
this pull request
Apr 19, 2023
eleanorjboyd
added a commit
that referenced
this pull request
Apr 19, 2023
eleanorjboyd
added a commit
that referenced
this pull request
Apr 19, 2023
eleanorjboyd
added a commit
that referenced
this pull request
Apr 19, 2023
eleanorjboyd
added a commit
that referenced
this pull request
Apr 19, 2023
eleanorjboyd
added a commit
that referenced
this pull request
Apr 19, 2023
eleanorjboyd
added a commit
that referenced
this pull request
Apr 19, 2023
eleanorjboyd
added a commit
that referenced
this pull request
Apr 19, 2023
eleanorjboyd
added a commit
that referenced
this pull request
Apr 19, 2023
eleanorjboyd
added a commit
that referenced
this pull request
Apr 19, 2023
eleanorjboyd
added a commit
that referenced
this pull request
Apr 19, 2023
eleanorjboyd
added a commit
that referenced
this pull request
Apr 19, 2023
eleanorjboyd
added a commit
that referenced
this pull request
Apr 19, 2023
eleanorjboyd
added a commit
that referenced
this pull request
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This logic now successfully works to discover the pytest repo tests.
This branch takes into account all the previous comments made to the
python discovery logic in the previous PR (located on my personal fork).
Therefore this is a second round of edits on this code. It now works for
the pytest library (discovers all the tests in the pytest library).
Co-authored-by: Brett Cannon brcan@microsoft.com
Co-authored-by: Karthik Nadig kanadig@microsoft.com