Skip to content

Commit

Permalink
Change the outdated browser prompt classname
Browse files Browse the repository at this point in the history
While the outdated browser prompt currently links to `browsehappy.com`,
users are free and even encouraged to substitute the link with their own
page or site of preference.

This commit changes the `browsehappy` specific classname with the more
agnostic `browserupgrade` in order to make the link substitution
easier, but more importantly to hint to the users that they don't have
to stick with the currently default provided `browsehappy.com` link.

Ref: h5bp/html5-boilerplate#1582
     h5bp/html5-boilerplate#1608

Close h5bp/html5-boilerplate#1608
  • Loading branch information
Andrew Brinker authored and alrra committed Oct 6, 2014
1 parent 3a22f71 commit ae83773
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 8 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
### HEAD

* Change the outdated browser prompt classname to `browserupgrade`
([#1608](https://github.com/h5bp/html5-boilerplate/issues/1608)).
* Update to Normalize.css 3.0.2.
([#1050](https://github.com/h5bp/html5-boilerplate/issues/1050)).
* Update `apple-touch-icon-precomposed.png` and the _"Apple touch
Expand Down
4 changes: 2 additions & 2 deletions dist/css/main.css
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,10 @@ textarea {
}

/* ==========================================================================
Browse Happy prompt
Browser Upgrade Prompt
========================================================================== */

.browsehappy {
.browserupgrade {
margin: 0.2em 0;
background: #ccc;
color: #000;
Expand Down
2 changes: 1 addition & 1 deletion dist/doc/html.md
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ The central part of the boilerplate template is pretty much empty. This is
intentional, in order to make the boilerplate suitable for both web page and
web app development.

### BrowseHappy Prompt
### Browser Upgrade Prompt

The main content area of the boilerplate includes a prompt to install an up to
date browser for users of IE 6/7. If you intended to support IE 6/7, then you
Expand Down
2 changes: 1 addition & 1 deletion dist/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
</head>
<body>
<!--[if lt IE 8]>
<p class="browsehappy">You are using an <strong>outdated</strong> browser. Please <a href="http://browsehappy.com/">upgrade your browser</a> to improve your experience.</p>
<p class="browserupgrade">You are using an <strong>outdated</strong> browser. Please <a href="http://browsehappy.com/">upgrade your browser</a> to improve your experience.</p>
<![endif]-->

<!-- Add your site or application content here -->
Expand Down
4 changes: 2 additions & 2 deletions src/css/main.css
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,10 @@ textarea {
}

/* ==========================================================================
Browse Happy prompt
Browser Upgrade Prompt
========================================================================== */

.browsehappy {
.browserupgrade {
margin: 0.2em 0;
background: #ccc;
color: #000;
Expand Down
2 changes: 1 addition & 1 deletion src/doc/html.md
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ The central part of the boilerplate template is pretty much empty. This is
intentional, in order to make the boilerplate suitable for both web page and
web app development.

### BrowseHappy Prompt
### Browser Upgrade Prompt

The main content area of the boilerplate includes a prompt to install an up to
date browser for users of IE 6/7. If you intended to support IE 6/7, then you
Expand Down
2 changes: 1 addition & 1 deletion src/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
</head>
<body>
<!--[if lt IE 8]>
<p class="browsehappy">You are using an <strong>outdated</strong> browser. Please <a href="http://browsehappy.com/">upgrade your browser</a> to improve your experience.</p>
<p class="browserupgrade">You are using an <strong>outdated</strong> browser. Please <a href="http://browsehappy.com/">upgrade your browser</a> to improve your experience.</p>
<![endif]-->

<!-- Add your site or application content here -->
Expand Down

0 comments on commit ae83773

Please sign in to comment.