Usage of new elcodi related purchasable service #627
Conversation
mmoreram
commented
Nov 9, 2015
mmoreram
commented
- Using related products as subrequests, using new service
- Deprecated ProductCollectionProvider in favor of new elcodi/elcodi implementation
- Fixed some finish translations (only format)
| {% include "@StoreTemplate/Modules/_product-related.html.twig" with {'products' : related_products} %} | ||
| {{ render(url('store_product_related', { | ||
| 'id': product.id | ||
| })) }} |
There was a problem hiding this comment.
I'm not fully sure about this change, the render adds an overhead, is this necessary?
There was a problem hiding this comment.
yes, sure, is the way to really uncouple both features :)
There was a problem hiding this comment.
ok, than the only change could be replacing url with path, but this doesn't change so much
There was a problem hiding this comment.
I usually don't use the url function at all to prevent requests problems when switching from render to render_hinclude.
Anyway probably this isn't a related case.
|
Tests are actually green on master, any idea why they aren't passing for this PR? |
|
@EmanueleMinotto in faxr, master is failing as well. This requires new version of Needs to be fixed. |
* Using related products as subrequests, using new service * Deprecated ProductCollectionProvider in favor of new elcodi/elcodi implementation * Fixed some finish translations (only format) Also : Removed logic from listener * This change is because of new final events * Placed this logic into a service * Fixed tests (listeners shouln't have tests. Now service is tested)
mmoreram
force-pushed
the
feature/new-related-purchasables-usage
branch
from
015089c to
f8c77f2
Compare
…usage Usage of new elcodi related purchasable service
