Added Bridge for Visithor Bundle #430
Conversation
mmoreram
commented
May 3, 2015
mmoreram
commented
- Added initial visithor configuration file
- Added visithor test to travis
| @@ -169,6 +169,9 @@ public function registerBundles() | |||
| $bundles[] = new Elcodi\Bundle\FixturesBoosterBundle\ElcodiFixturesBoosterBundle(); | |||
| $bundles[] = new Symfony\Bundle\WebProfilerBundle\WebProfilerBundle(); | |||
| $bundles[] = new Sensio\Bundle\DistributionBundle\SensioDistributionBundle(); | |||
|
|
|||
| $bundles[] = new \Elcodi\Common\VisithorBridgeBundle\VisithorBridgeBundle(); | |||
There was a problem hiding this comment.
please avoid introducing these slashes
|
Is this just a test mechanism for smoke tests? if so I believe there are better solutions for this already no? Even with bldr I can run those commands already with predefined inputs and things. Why making this part of the application? |
|
@cordoval This is just to ensure that all these urls are available. That's it. I made this project because it is really useful for me and the project. Easy and painless (not like Behat, btw...), and we have the control of the evolution of the project. This week, first version. |
mmoreram
force-pushed
the
feature/added-visithor
branch
6 times, most recently
from
a54e02f to
8e5d645
Compare
| { | ||
| gc_collect_cycles(); | ||
|
|
||
| $application = new Application($kernel); |
There was a problem hiding this comment.
you are creating another application instance, if you are running this as a command there is already one, all those commands can be found and executed, no need for doing it like this ...
|
I don't think behat is hard. But you could even write a phpunit test to do this or even just a reusable command anyway. Imo 👎 but your call. 👍 |
|
Okay, thanks for your POV. Take in account that a project that is not interesting for you can be interesting for other people. Not everyone has the same sense of technology, and for example, I spent a lot of time with Behat to make it work. This means that a lot of projects just discard the idea of using Behat (because of many reasons than we both will know nor understand), so this project will be so helpful because is so easy to understand and install/configure So, given this premise, if this project is helpful for almost one single project, then I will be satisfied... and what happens is that it is already helpful for me :) So... enough! ^^ Thanks for your comments here, I will review it right now! |
|
@cordoval btw, how can you inject the full application? |
mmoreram
force-pushed
the
feature/added-visithor
branch
7 times, most recently
from
c3a0678 to
2ed54c8
Compare
* Added initial visithor configuration file * Added visithor test to travis with green result * Added default carrier ranges to cover basic scenario * Fixed routes to make visithor pass * Moved phpunit.xml.dist to the root * Fixed workflow product test
mmoreram
force-pushed
the
feature/added-visithor
branch
from
2ed54c8 to
c101c6c
Compare
Added Bridge for Visithor Bundle
