Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 5 compatability updates #1

Merged
merged 3 commits into from
Feb 13, 2020
Merged

Symfony 5 compatability updates #1

merged 3 commits into from
Feb 13, 2020

Conversation

iisisrael
Copy link

Cleans up recent changes, and moves templating to Twig.

@iisisrael
Copy link
Author

I can also try reverting the getters added to the managers and form handler that were added here only for tests, and use reflection classes for the assertions instead. And there's still two warnings and two tests marked incomplete that I can look into.

@elchris
Copy link
Owner

elchris commented Feb 13, 2020

I can also try reverting the getters added to the managers and form handler that were added here only for tests, and use reflection classes for the assertions instead. And there's still two warnings and two tests marked incomplete that I can look into.

Oh yes I would absolutely love it if you could replace my getter/setters with reflection, I didn't do it myself because I lack experience with it, so that would be awesome.

And yes, I tried addressing those two warnings but I wasn't able to handle them, so if you could look at those too, that'd be great.

There were two tests already marked incomplete when I first pulled the project, and I added a third one indicating that it appeared to only be testing something for backward-compatibility, so I would start by looking at this 3rd one, and then perhaps if you want too look at the two older ones, that's cool too, but you might find them beyond the scope of this.

Thank you @iisisrael !!!

@iisisrael
Copy link
Author

There were two tests already marked incomplete when I first pulled the project, and I added a third one indicating that it appeared to only be testing something for backward-compatibility

I actually removed that test, as the token storage compiler pass is no longer necessary.

@elchris elchris merged commit da7fd54 into elchris:symfony-5 Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants