-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc example improvement: 400 should not retry #176
Comments
Hey @dmudro 👋
Thanks!
You are absolutely right, this should be the default behaviour to skip retrying on 4xx errors. But until wretch v3.x.x is released (to avoid a breaking change) I just pushed a commit to clarify it in the readme and typescript doc. |
Hey, I tried digging in the lib but I'm not sure I understand correctly. The retry mechanism happens only when using the retry middleware right? If I use wretch without anything else, I should have no retry when I'm calling my function? |
Hey, yes it is only when adding the retry middleware. |
been using wretch for some time, nice little lib indeed.
it might be worth tweaking the retry example or defaults to ignore certain http responses that should almost never retry.
we had a case with Zoom API recently where initial POST resulted in
400 Bad Request
which retried a few times and subsequently causing429 Too Many Requests
. things like 400 bad request is almost always client's fault!maybe adding a simple check in the doc or adding a new option / default?
The text was updated successfully, but these errors were encountered: