Elasticsearch trust settings: Only add them to the update payload if there are changes. #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…there are changes. The trust setting should only be added to the payload when they change. If they are left out of the payload, no changes to the trust will be made.
gigerdo
force-pushed
the
only-update-trust-if-there-are-changes
branch
from
4495f4f
to
21c4864
Compare
nick-benoit
reviewed
Sep 20, 2024
ec/ecresource/deploymentresource/elasticsearch/v2/elasticsearch_payload.go
Show resolved
Hide resolved
dimuon
approved these changes
Sep 23, 2024
nick-benoit
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trust setting should only be added to the payload when they change. If they are left out of the payload, no changes to the trust will be made.
This is a partial fix/workaround for #842
Description
Related Issues
#842
Motivation and Context
How Has This Been Tested?
Types of Changes
Readiness Checklist