Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP-5474] Add ML nodes autoscaling support #761

Merged
merged 11 commits into from
Jan 16, 2024
Merged

Conversation

mieciu
Copy link
Contributor

@mieciu mieciu commented Jan 11, 2024

A good while ago I've added an option to scale only Elasticsearch ML tier in ESS. This PR brings this feature to our TF provider.

Resource declaration looks like this:

  elasticsearch = {
    hot = {
      autoscaling = {}
    }
    
    ml = {
       autoscaling = {
          autoscale = true
       }
    }
    
  }

Tested it on the actual environment and it looks like it's working nicely:

image

@mieciu mieciu force-pushed the ml-autoscale branch 3 times, most recently from 4a4618e to b4b5f25 Compare January 11, 2024 13:44
@mieciu mieciu marked this pull request as ready for review January 15, 2024 09:20
@mieciu mieciu requested a review from a team as a code owner January 15, 2024 09:20
@mieciu mieciu requested a review from dimuon January 15, 2024 09:20
@mieciu
Copy link
Contributor Author

mieciu commented Jan 15, 2024

Apparently the acceptance test I've added passes (TestAccDeploymentWithMLOnlyAutoscale (200.23s)), but an unrelated one is failing (TestAccDeployment_integrationsServer).

UPDATE: Looks like a a flakiness, I got it passing locally.

Copy link
Contributor

@dimuon dimuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mieciu mieciu merged commit 0df175f into elastic:master Jan 16, 2024
2 checks passed
@dimuon dimuon changed the title Add ML nodes autoscaling support [CP-5474] Add ML nodes autoscaling support Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants