Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set size to unknown if other extension attributes change #749

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Set size to unknown if other extension attributes change #749

merged 2 commits into from
Dec 5, 2023

Conversation

tobio
Copy link
Member

@tobio tobio commented Nov 29, 2023

Related Issues

Fixes #748

How Has This Been Tested?

Unit/acceptance

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@tobio tobio self-assigned this Nov 29, 2023
@tobio tobio requested a review from a team as a code owner November 29, 2023 11:22
dimuon
dimuon approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@dimuon dimuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobio tobio merged commit 0f0fec8 into elastic:master Dec 5, 2023
@tobio tobio deleted the set-size-to-unknown-on-change branch December 5, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimuon dimuon dimuon approved these changes

Assignees

@tobio tobio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure while updating extension bundle
2 participants
@tobio @dimuon