Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment/topologies set #573

Closed
wants to merge 93 commits into from

Conversation

dimuon
Copy link
Contributor

@dimuon dimuon commented Jan 18, 2023

Description

An alternative to #567 approach to Elasticsearch topology. The PR represents it as a set.

The PR is still in the experimental stage!!!

Related Issues

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

dimuon and others added 30 commits September 6, 2022 14:33
Introduce mux and port the provider to v6.
Migrate data sources to terraform-provider-framework
Migrate resource ec_deployment_traffic_filter_association to terraform-provider-framework
…ork-0.12

Update to terraform-plugin-framework 0.12 and fix import order
…ramework

The behavior of the default_value plan_modifier changes, so
it also applies default values when the value has been explicitly
specified before.

Unit test timeout increased.

Switch to v6 provider in tests.
Migrate resource ec_deployment_traffic_filter to terraform-provider-framework
* Use ListNestedAttributes for nested schemas in datasource ec_stack
* Use ListNestedAttributes for nested schemas in datasource ec_deployment
* Use blocks and ListNestedAttributes for nested schemas in datasource ec_deployments
…ugin-framework (#10)

Co-authored-by: Pascal Hofmann <pascal.hofmann.ext@gec.io>
Update dependencies and remove external provider workaround from migration tests
#12)

* Migrate resource ec_deployment_extension to terraform-plugin-framework

* Remove useless use of ec.Bool() and ec.String()

Co-authored-by: Pascal Hofmann <pascal.hofmann.ext@gec.io>
@cla-checker-service
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
2194ad3, 8a79970, c197f28, , , b00e28a,

Please, read and sign the above mentioned agreement if you want to contribute to this project

@dimuon
Copy link
Contributor Author

dimuon commented Jan 25, 2023

The current TF core logic (TF client 1.3.7) makes it impossible to use sets with more than one computed + optional underlying attributes that means, in particular, that Elasticsearch topology (where a tier object has more than one computed and optional attributes) cannot be represented by a set (tfsdk.SetNestedAttributes).
More details:

@dimuon dimuon closed this Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants