Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: require node > 14 for usage #397

Merged
merged 2 commits into from
Oct 13, 2021
Merged

chore: require node > 14 for usage #397

merged 2 commits into from
Oct 13, 2021

Conversation

vigneshshanmugam
Copy link
Member

  • We have already migrated HB to use Node 14 and also changed our nvmrc to use Node 14
  • This change would require users installing the agent to be on Node 14 to not throw errors when using incompatible APIs like fs/promises which is available only from Node 14.14

@apmmachine
Copy link

apmmachine commented Oct 13, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-13T17:43:55.516+0000

  • Duration: 19 min 10 sec

  • Commit: 923f42b

Test stats 🧪

Test Results
Failed 0
Passed 140
Skipped 0
Total 140

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@vigneshshanmugam
Copy link
Member Author

/test

@vigneshshanmugam vigneshshanmugam merged commit ffafe21 into elastic:master Oct 13, 2021
@vigneshshanmugam vigneshshanmugam deleted the require-node-14 branch October 13, 2021 18:14
v1v added a commit to dominiqueclarke/synthetics that referenced this pull request Nov 22, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/360-kiban…
001fab1 
…a-fleet-heartbeat-synthetics-e2e-tests

* upstream/master:
  [jjbb] for scheduling e2e jobs (elastic#418)
  docs: release notes for beta.17 (elastic#415)
  1.0.0-beta.17
  feat: add --playwright-options (elastic#405)
  fix: ensure timestamps of events are inorder (elastic#413)
  fix: do not stash `.nvm` folder (elastic#414)
  deprecate suite-params option over params (elastic#406)
  fix: end timestamp should reflect duration (elastic#410)
  docs: release notes for 1.16.0 (elastic#403)
  1.0.0-beta.16
  fix: revert Playwright to 1.14.0 (elastic#402)
  docs: release notes for beta 15 (elastic#400)
  1.0.0-beta.15
  chore: update deps and fix lint issues (elastic#399)
  fix: handle page close during response event (elastic#398)
  chore: require node > 14 for usage (elastic#397)
  fix: fix megabytes to mbps (elastic#394)
  feat: enable trace as part of rich-events (elastic#387)
  feat: use events from PW for network data (elastic#372)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vigneshshanmugam @apmmachine