-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: perf relative traces and values #306
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
const events = trace.mainThreadEvents; | ||
const { score, event } = this.computeCLSValue(events); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all CLS relative trace events will be added as part of the work in #301
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some more missing units, otherwise got. Looking better!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, so much cleaner with easy to read units :)
browser.relative_trace
to keep the mapping similar and these traces are mark or measure events withstart
andend
time denoting the time when particular event (LCP, FCP, etc) occurred during the waterfall.browser.experience.<metric-name>
to keep the querying easier in the UI and useful for displaying values in step detail page.Relative trace events
Experience metrics