Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade] Upgrade Synthetics to v1.0.0 and migrate code gen from Recorder to Synthetics #412

Merged

Conversation

justinkambic
Copy link
Contributor

@justinkambic justinkambic commented May 9, 2023

Summary

Resolves #295.

Resolves #393.

Upgrades the recorder to use v1.0.0 of Synthetics 🎉

Migrates code generation to the synthetics library.

In draft state, code not ready for review.

All checks are passing, this should be ready to review.

Implementation details

Bumps both Synthetics and Playwright to the version used by Synthetics.

Deletes code gen from the recorder and references updated code in Synthetics lib.

How to validate this change

Make sure the recorder works as intended, specifically WRT generated code.

  • Download and smoke test the recorder
  • Record multiple journeys
  • Make sure code export works ok
  • Ensure the "test" feature of the recorder is working and instrumenting the browser properly

@justinkambic justinkambic added chore dependencies Pull requests that update a dependency file labels May 9, 2023
@justinkambic justinkambic self-assigned this May 9, 2023
@justinkambic justinkambic force-pushed the migrate-to-synthetics-generator branch from 90e9f85 to d775143 Compare May 10, 2023 13:51
@justinkambic justinkambic force-pushed the migrate-to-synthetics-generator branch from d775143 to 2ac3a8b Compare May 10, 2023 13:52
@justinkambic justinkambic changed the title [Draft] Migrate to synthetics generator [Upgrade] Upgrade Synthetics to v1.0.0 and migrate code gen from Recorder to Synthetics May 10, 2023
@justinkambic justinkambic marked this pull request as ready for review May 10, 2023 14:07
@justinkambic
Copy link
Contributor Author

As part of development on this branch, I've added a global.d.ts file to hack around some TypeScript issues with how Synthetics imports the JS language generator from Playwright. This didn't come up in my pre-patch testing before Synthetics v1 was released, but it's happening now that I've imported the actual released package.

I've created a bug issue to track this, we can circle back later and see if we can create a cleaner solution.

Copy link
Contributor

@kyungeunni kyungeunni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is huge. Thanks, @justinkambic!!
Tested locally, and everything works great for me 🏅

p.s.
image
YAY to all the deletions!!! 🧹

@justinkambic justinkambic merged commit 6d9b314 into elastic:main May 11, 2023
@justinkambic justinkambic deleted the migrate-to-synthetics-generator branch May 11, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore dependencies Pull requests that update a dependency file
Projects
None yet
2 participants