-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Upgrade] Upgrade Synthetics to v1.0.0 and migrate code gen from Recorder to Synthetics #412
[Upgrade] Upgrade Synthetics to v1.0.0 and migrate code gen from Recorder to Synthetics #412
Conversation
…om Recorder codebase.
90e9f85
to
d775143
Compare
d775143
to
2ac3a8b
Compare
…t`, `Steps` and `Step` from Recorder repo.
As part of development on this branch, I've added a I've created a bug issue to track this, we can circle back later and see if we can create a cleaner solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is huge. Thanks, @justinkambic!!
Tested locally, and everything works great for me 🏅
Summary
Resolves #295.
Resolves #393.
Upgrades the recorder to use v1.0.0 of Synthetics 🎉
Migrates code generation to the synthetics library.
In draft state, code not ready for review.All checks are passing, this should be ready to review.
Implementation details
Bumps both Synthetics and Playwright to the version used by Synthetics.
Deletes code gen from the recorder and references updated code in Synthetics lib.
How to validate this change
Make sure the recorder works as intended, specifically WRT generated code.