-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds info about when to use data frames #435
Conversation
You can preview this content here: http://stack-docs_435.docs-preview.app.elstc.co/guide/en/elastic-stack-overview/master/ml-dataframes.html |
@sophiec20 FYI I added a subsection in the introductory "Data frame transforms" page, per your suggestion. |
composite aggregation, the transform receives partial results. The aggregated | ||
search is retried with a smaller number of buckets. This retry is performed at | ||
the interval defined in the transform's `frequency` property. If the search | ||
is retried to the point where it reaches a minimal number of buckets, an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this minimal number of buckets configurable or visible to users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is 10 (which is fixed and also the minimum value for max_page_search_size
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please remove final sentence In general, the design of data frame transforms favors data consistency over continuous running.
-- it reads funny and does not add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor feedback
composite aggregation, the transform receives partial results. The aggregated | ||
search is retried with a smaller number of buckets. This retry is performed at | ||
the interval defined in the transform's `frequency` property. If the search | ||
is retried to the point where it reaches a minimal number of buckets, an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is 10 (which is fixed and also the minimum value for max_page_search_size
)
composite aggregation, the transform receives partial results. The aggregated | ||
search is retried with a smaller number of buckets. This retry is performed at | ||
the interval defined in the transform's `frequency` property. If the search | ||
is retried to the point where it reaches a minimal number of buckets, an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please remove final sentence In general, the design of data frame transforms favors data consistency over continuous running.
-- it reads funny and does not add.
This PR moves the content from docs/en/stack/data-frames/dataframes.asciidoc into a lower-level "Overview" page. It then adds information to the highest-level "Data frame transforms" page about when it makes sense to use data frames instead of aggregations.