Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds info about when to use data frames #435

Merged
merged 10 commits into from
Jul 24, 2019
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jul 19, 2019

This PR moves the content from docs/en/stack/data-frames/dataframes.asciidoc into a lower-level "Overview" page. It then adds information to the highest-level "Data frame transforms" page about when it makes sense to use data frames instead of aggregations.

@lcawl
Copy link
Contributor Author

lcawl commented Jul 19, 2019

@lcawl
Copy link
Contributor Author

lcawl commented Jul 19, 2019

@sophiec20 FYI I added a subsection in the introductory "Data frame transforms" page, per your suggestion.

composite aggregation, the transform receives partial results. The aggregated
search is retried with a smaller number of buckets. This retry is performed at
the interval defined in the transform's `frequency` property. If the search
is retried to the point where it reaches a minimal number of buckets, an
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this minimal number of buckets configurable or visible to users?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is 10 (which is fixed and also the minimum value for max_page_search_size)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please remove final sentence In general, the design of data frame transforms favors data consistency over continuous running. -- it reads funny and does not add.

Copy link

@sophiec20 sophiec20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor feedback

composite aggregation, the transform receives partial results. The aggregated
search is retried with a smaller number of buckets. This retry is performed at
the interval defined in the transform's `frequency` property. If the search
is retried to the point where it reaches a minimal number of buckets, an

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is 10 (which is fixed and also the minimum value for max_page_search_size)

composite aggregation, the transform receives partial results. The aggregated
search is retried with a smaller number of buckets. This retry is performed at
the interval defined in the transform's `frequency` property. If the search
is retried to the point where it reaches a minimal number of buckets, an

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please remove final sentence In general, the design of data frame transforms favors data consistency over continuous running. -- it reads funny and does not add.

@lcawl lcawl merged commit 3007abe into elastic:master Jul 24, 2019
@lcawl lcawl deleted the df-lower branch July 24, 2019 18:57
lcawl added a commit that referenced this pull request Jul 24, 2019
lcawl added a commit that referenced this pull request Jul 24, 2019
lcawl added a commit that referenced this pull request Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants