Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add security:authentication jobs #1813

Merged
merged 7 commits into from
Sep 16, 2021
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Sep 10, 2021

@lcawl lcawl marked this pull request as ready for review September 13, 2021 22:45
Copy link

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest edits LGTM

Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates LGTM!

Added a comment around how security uses the recognize API to determine supported modules -- if @peteharverson verifies this is the same behavior as running the query in the module's manifest.json then I think the existing language is good. 👍

@lcawl lcawl merged commit b8926ad into elastic:main Sep 16, 2021
@lcawl lcawl deleted the security-auth branch September 16, 2021 20:36
lcawl added a commit to lcawl/stack-docs that referenced this pull request Sep 16, 2021
lcawl added a commit to lcawl/stack-docs that referenced this pull request Sep 16, 2021
lcawl added a commit to lcawl/stack-docs that referenced this pull request Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants