Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc][SIEM]General corrections #1001

Merged
merged 9 commits into from
Apr 22, 2020

Conversation

benskelker
Copy link
Contributor

@benskelker benskelker commented Apr 20, 2020

Adds licensing requirements and list of substituted timeline query field values.

Preview of timeline field value substitutions

Copy link

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@MikePaquette MikePaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments added, but looking good.

@@ -93,9 +96,39 @@ To open and close signals, either:
*Close/Open selected*.

[float]
[[signals-to-timelines]]
=== Send signals to the Timeline

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use "Investigate signals in Timeline" rather than "Send". (Send implies that you might be moving it to the timeline, but it will actually stay in the signals table).


*Example*

The timeline template used in the rule has this query:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace "query" with "dropzone query". (I know it seems overly detailed, but to avoid confusion with Saved Queries or KQL queries, I think we should repeat "dropzone" each time.)

`host.name: "Linux-LiverpoolFC"`. When signals generated by the rule are sent
to the Timeline, the `host.name` value is replaced with the signal's
`host.name` value. If the signal's `host.name` value is `Windows-ArsenalFC`,
the timeline query is `host.name: "Windows-ArsenalFC"`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again "dropzone query"

To investigate a signal in the Timeline, click the *Investigate in timeline*
icon.

If the rule that generated the signal uses a timeline template, when you send

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change "when you send" to "when you investigate"

icon.

If the rule that generated the signal uses a timeline template, when you send
the signal to the Timeline, the following dropzone query values are replaced

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change "to the Timeline" to "in the Timeline"

Copy link

@MikePaquette MikePaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benskelker benskelker merged commit c7c3df1 into elastic:master Apr 22, 2020
@benskelker benskelker deleted the general_corrections branch April 22, 2020 13:17
benskelker added a commit to benskelker/stack-docs that referenced this pull request Apr 22, 2020
* adds license requirements

* adds timeline field subs

* wording

* typo

* expands example

* corrects api urls

* finalises licensing text

* fixes list formatting

* corrections after review
benskelker added a commit to benskelker/stack-docs that referenced this pull request Apr 22, 2020
* adds license requirements

* adds timeline field subs

* wording

* typo

* expands example

* corrects api urls

* finalises licensing text

* fixes list formatting

* corrections after review
benskelker added a commit that referenced this pull request Apr 22, 2020
* adds license requirements

* adds timeline field subs

* wording

* typo

* expands example

* corrects api urls

* finalises licensing text

* fixes list formatting

* corrections after review
benskelker added a commit that referenced this pull request Apr 22, 2020
* adds license requirements

* adds timeline field subs

* wording

* typo

* expands example

* corrects api urls

* finalises licensing text

* fixes list formatting

* corrections after review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants