-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom roles & privileges: Revise, reorder, add serverless requirements pages #5779
Merged
Merged
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
8507a1f
First draft: add Defend feature privs page
joepeeples eab88f8
Test if bad link within conditional will break
joepeeples 3efff46
Alas, CI doesn't catch bad links in conditionals
joepeeples ebca100
Temporarily comment out conditionals
joepeeples 85fe51f
Li'l edit for active voice
joepeeples 055a61f
Reorg serverless req pages to match ESS
joepeeples c26a764
Align page titles
joepeeples d2b8a3e
Move serverless source files for req pages
joepeeples 19b290b
Merge branch 'main' into 11-custom-roles-serverless
joepeeples d747478
Remove old draft files (duplicates)
joepeeples 10cce74
Merge branch 'main' into 11-reqs-reorg
joepeeples cb69ca1
Revise "Elastic Security requirements"
joepeeples 2700e9b
Minor edits
joepeeples afe4659
Another edit
joepeeples 245b4f9
Revise "Network map data" page
joepeeples 4ae057c
Minor revision to "ML job and rule reqs"
joepeeples 1cb4a2e
Merge branch 'main' into 11-reqs-revise-custom-roles
joepeeples 425d080
Change terminology: predefined user role
joepeeples aa228d6
Revise "Entity risk scoring" page
joepeeples ad4ffa0
Revise "Cases requirements"
joepeeples 321326d
Remove image
joepeeples 3c42aed
Merge branch 'main' into 11-reqs-reorg
joepeeples 1bb985c
Merge branch 'main' into 11-reqs-revise-custom-roles
joepeeples 639e095
Merge branch '11-reqs-reorg' into 11-reqs-revise-custom-roles
joepeeples e81039f
Merge branch '11-custom-roles-serverless' into 11-reqs-revise-custom-…
joepeeples f6993c1
Remove image: Defend feature privs
joepeeples 5d3a820
Revise "Detections requirements"
joepeeples dce29b9
Temporarily comment out conditionals in Detections
joepeeples 763d515
Revise "Advanced settings"
joepeeples 2cbac1d
Revise "Endpoint response actions"
joepeeples 9977827
Merge branch 'main' into 11-reqs-revise-custom-roles
joepeeples 3ee68ce
Merge branch 'main' into 11-reqs-revise-custom-roles
joepeeples 1501550
Merge branch 'main' into 11-reqs-revise-custom-roles
joepeeples 13b74ac
Merge branch 'main' into 11-reqs-revise-custom-roles
joepeeples 5669295
Merge branch 'main' into 11-reqs-revise-custom-roles
joepeeples 344ad5b
Merge branch 'main' into 11-reqs-revise-custom-roles
joepeeples ca2945c
Un-comment conditionals
joepeeples 2a74fac
Indent conditional contents (for readability)
joepeeples c8b0208
Fix ML requirements
joepeeples 39c3dde
Apply feedback from Janeen's review
joepeeples 7168226
Merge branch 'main' into 11-reqs-revise-custom-roles
joepeeples File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit but curious as to why
Maps
is in monospace here? I would think quotes or bold emphasis.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's how it was previously formatted, and historically we tend to use monospace for privileges (such as in the Detections privs table, "Kibana Privileges" column). I tend to agree that bold might be more appropriate for privs and features since they're UI elements, not text that the user types, but also hesitant to change this and make it less consistent with other feature privs.