Allow to abort on fatal errors #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we add a third option to the command line parameter `on-error`. So far it has been possible to either continue or abort on error. Now we also allow to continue except for errors that indicate that the cluster is unreachable (e.g. because it died with an OOME).
danielmitterdorfer
added
enhancement
dliappis
approved these changes
May 19, 2020
docs/command_line_reference.rst
Outdated
| This option controls how Rally behaves when a response error occurs. The following values are possible: | ||
|
|
||
| * ``continue``: only records that an error has happened and will continue with the benchmark. At the end of a race, errors show up in the "error rate" metric. | ||
| * ``continue-on-non-fatal`` (default): Behaves as ``continue`` but aborts the benchmark immediately on all fatal errors. At the moment a refused connection is considered fatal. All other errors are considered non-fatal. |
There was a problem hiding this comment.
I had to reread a few times the second sentence (At the moment a refused connection is considered fatal.). I don't think we need to explain that this may (or not) change in the future.
I suggest we just state that the only fatal error is receiving "Connection Refused"
(ECONNREFUSED) / (http://man7.org/linux/man-pages/man2/connect.2.html)
There was a problem hiding this comment.
Thanks! Addressed in 9925e35.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we add a third option to the command line parameter
on-error. So far it has been possible to either continue or abort onerror. Now we also allow to continue except for errors that indicate
that the cluster is unreachable (e.g. because it died with an OOME).