Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental segment stats telemetry device #988

Merged

Conversation

danielmitterdorfer
Copy link
Member

With this commit we add a new telemetry device that writes segments
stats at the end of a benchmark to a log file. This telemetry device is
currently considered experimental (i.e. it may be removed at any time)
and is thus also intentionally undocumented.

With this commit we add a new telemetry device that writes segments
stats at the end of a benchmark to a log file. This telemetry device is
currently considered experimental (i.e. it may be removed at any time)
and is thus also intentionally undocumented.
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Telemetry Telemetry Devices that gather additional metrics labels May 6, 2020
@danielmitterdorfer danielmitterdorfer added this to the 2.0.0 milestone May 6, 2020
@danielmitterdorfer danielmitterdorfer requested a review from hub-cap May 6, 2020 12:12
@danielmitterdorfer danielmitterdorfer self-assigned this May 6, 2020
Copy link
Contributor

@hub-cap hub-cap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent. I was about to ask why it was not documented and then went and read the commit msg. All your ducks are in a row!

@danielmitterdorfer
Copy link
Member Author

Thanks for the quick review!

@danielmitterdorfer danielmitterdorfer merged commit 668be21 into elastic:master May 6, 2020
@danielmitterdorfer danielmitterdorfer deleted the segment-stats branch May 6, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo :Telemetry Telemetry Devices that gather additional metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants