Allow to override Python binary for make #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we expose a new make variable `PY_BIN` which defaults to `python3` to keep the current behavior. However, this change allows to experiment with other Python implementations like pypy by specifying `make venv-create PY_BIN=pypy3` (provided pypy has been installed correctly on the system; adding support for this is intentionally out of scope for this PR). While this does not mean we will start supporting pypy, it allows us to experiment with it.
danielmitterdorfer
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we expose a new make variable
PY_BINwhich defaultsto
python3to keep the current behavior. However, this change allowsto experiment with other Python implementations like pypy by specifying
make venv-create PY_BIN=pypy3(provided pypy has been installedcorrectly on the system; adding support for this is intentionally out of
scope for this PR). While this does not mean we will start supporting
pypy, it allows us to experiment with it.