Show recent log output on integration test failure #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a CI failure occurs in integration tests we usually have very little output to analyze the failure. Furthermore, CI workers are ephemeral so we also lose access to logs. With this commit we check whether there was a failure and dump the most recent Rally logs.
danielmitterdorfer
added
enhancement
dliappis
approved these changes
Jan 28, 2020
we need more visibility into those pesky failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a CI failure occurs in integration tests we usually have very
little output to analyze the failure. Furthermore, CI workers are
ephemeral so we also lose access to logs. With this commit we check
whether there was a failure and dump the most recent Rally logs.