Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix W1201. #869

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Fix W1201. #869

merged 1 commit into from
Jan 14, 2020

Conversation

drawlerr
Copy link
Contributor

Pass formatting arguments to log function instead of string format.

Relates #838

@drawlerr drawlerr added the cleanup Linter changes, reformatting, removal of unused code etc. label Jan 14, 2020
@drawlerr drawlerr added this to the 1.5.0 milestone Jan 14, 2020
dliappis
dliappis approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks.

This is especially useful, it's a rather easy to forget in PRs and default to format() or % so I am glad that we have it enabled now.

@drawlerr drawlerr merged commit bdef61c into elastic:master Jan 14, 2020
@drawlerr drawlerr deleted the w1201 branch January 14, 2020 15:48
@danielmitterdorfer danielmitterdorfer modified the milestones: 1.5.0, 1.4.0 Jan 15, 2020
@dliappis dliappis mentioned this pull request Jan 17, 2020
Closed
46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

@hub-cap hub-cap Awaiting requested review from hub-cap

@danielmitterdorfer danielmitterdorfer Awaiting requested review from danielmitterdorfer

@ebadyano ebadyano Awaiting requested review from ebadyano

Assignees
No one assigned
Labels
cleanup Linter changes, reformatting, removal of unused code etc.
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@drawlerr @dliappis @danielmitterdorfer