Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint issue C0301 #855

Merged
merged 10 commits into from
Jan 13, 2020
Merged

Fix lint issue C0301 #855

merged 10 commits into from
Jan 13, 2020

Conversation

hub-cap
Copy link
Contributor

@hub-cap hub-cap commented Jan 8, 2020

Relates #838

@hub-cap hub-cap added :misc Changes that don't affect users directly: linter fixes, test improvements, etc. cleanup Linter changes, reformatting, removal of unused code etc. labels Jan 8, 2020
@hub-cap hub-cap added this to the 1.4.0 milestone Jan 8, 2020
@hub-cap
Copy link
Contributor Author

hub-cap commented Jan 8, 2020

my editor removed some of the lines that are addressed in #854 , which wont be an issue once its merged

@dliappis dliappis mentioned this pull request Jan 8, 2020
Closed
46 tasks
danielmitterdorfer
danielmitterdorfer approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hub-cap
Copy link
Contributor Author

hub-cap commented Jan 9, 2020

@elasticmachine run tests please

@hub-cap
Copy link
Contributor Author

hub-cap commented Jan 13, 2020 •
edited
Loading

@elasticmachine run tests please

This should fail w/ pipefail in place.

edit: the build failed, properly.

17:59:59 + make precommit
18:00:08 ************* Module esrally.client
18:00:08 esrally/client.py:26:0: C0301: Line too long (154/140) (line-too-long)
18:00:08 
18:00:08 ------------------------------------
18:00:08 Your code has been rated at 10.00/10
18:00:08 
18:00:08 Makefile:91: recipe for target 'lint' failed
...
18:00:19 Finished: FAILURE

@hub-cap hub-cap merged commit 6720348 into elastic:master Jan 13, 2020
@hub-cap hub-cap deleted the lint_C0301 branch January 13, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmitterdorfer danielmitterdorfer danielmitterdorfer approved these changes

Assignees
No one assigned
Labels
cleanup Linter changes, reformatting, removal of unused code etc. :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hub-cap @danielmitterdorfer