Store Disk I/O metrics if available #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we split the check for disk I/O metrics for reads and writes. This avoids the case when one of these metrics is either `None` or `0`, the other metric is still added to the metrics store (this scenario might happen if data is only written but never read so the read counter is zero). We also change the check to test for `None` explicitly because we even want to add metrics to the metrics store if the value is zero.
danielmitterdorfer
added
bug
|
Thanks for the review! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we split the check for disk I/O metrics for reads and
writes. This avoids the case when one of these metrics is either
Noneor
0, the other metric is still added to the metrics store (thisscenario might happen if data is only written but never read so the read
counter is zero). We also change the check to test for
Noneexplicitlybecause we even want to add metrics to the metrics store if the value is
zero.