Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify uses of distribution-version #834

Merged
merged 1 commit into from
Dec 13, 2019
Merged

Clarify uses of distribution-version #834

merged 1 commit into from
Dec 13, 2019

Conversation

dliappis
Copy link
Contributor

@dliappis dliappis commented Dec 3, 2019 •
edited
Loading

Enhance docs to clarify that the distribution-version cli arg
only influences launching nodes and that it shouldn't be used
together with the benchmark-only pipeline.

Closes #833

@dliappis dliappis added the :Docs Changes to the documentation label Dec 3, 2019
@dliappis dliappis added this to the 1.4.0 milestone Dec 3, 2019
@dliappis dliappis added the enhancement Improves the status quo label Dec 3, 2019
danielmitterdorfer
danielmitterdorfer approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dliappis dliappis merged commit 4b47fbc into elastic:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmitterdorfer danielmitterdorfer danielmitterdorfer approved these changes

@drawlerr drawlerr Awaiting requested review from drawlerr

Assignees
No one assigned
Labels
:Docs Changes to the documentation enhancement Improves the status quo
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Fail when distribution-version is used together with benchmark-only pipeline
2 participants
@dliappis @danielmitterdorfer