Add heapdump telemetry device #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we add a new telemetry device `heapdump` that allows users to capture a heapdump right before a node is shutdown. This can be useful together with `--on-error=abort` where we then want to know the state of the heap at this point.
danielmitterdorfer
added
enhancement
dliappis
requested changes
Oct 22, 2019
esrally/telemetry.py
Outdated
| def detach_from_node(self, node, running): | ||
| if running: | ||
| heap_dump_file = os.path.join(self.log_root, "heap_at_exit_{}.hprof".format(node.pid)) | ||
| console.info("{}: Writing heap dump to [{}}]".format(self.human_name, heap_dump_file), logger=self.logger) |
There was a problem hiding this comment.
This will error out as [{}]] needs to be [{}]. (Tests also fail)
There was a problem hiding this comment.
I've addressed it now in e44cbfe. Can you please have another look?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we add a new telemetry device
heapdumpthat allowsusers to capture a heapdump right before a node is shutdown. This can be
useful together with
--on-error=abortwhere we then want to know thestate of the heap at this point.