Store race files always as race.json #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we store the race file always as `race.json`. Previously Rally had a logic built-in to create a unique file name if there was a potential for duplicate race files (with the same race timestamp) but as we're using the race id now for the base directory this is not possible anymore. Relates elastic#720
danielmitterdorfer
added
enhancement
|
Thanks for the review! :) |
novosibman
pushed a commit
to novosibman/rally
that referenced
this pull request
Oct 2, 2019
With this commit we store the race file always as `race.json`. Previously Rally had a logic built-in to create a unique file name if there was a potential for duplicate race files (with the same race timestamp) but as we're using the race id now for the base directory this is not possible anymore. Relates elastic#720 Relates elastic#773
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we store the race file always as
race.json.Previously Rally had a logic built-in to create a unique file name if
there was a potential for duplicate race files (with the same race
timestamp) but as we're using the race id now for the base directory
this is not possible anymore.
Relates #720