Check that origin points to main repo for release #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we add a new pre-release check that ensures that the git remote named `origin` points to Rally's main repository instead of a fork. This is necessary for releases because later during the release process, changes will be pushed automatically to the main repository (such as the release tags). Closes elastic#717
danielmitterdorfer
added
enhancement
dliappis
reviewed
Sep 3, 2019
release-checks.sh
Outdated
| @@ -50,6 +50,13 @@ then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| ORIGIN_URL=$(git remote get-url --push origin) | |||
| if [[ $(echo ${ORIGIN_URL} | grep -c "elastic/rally") == "0" ]] | |||
There was a problem hiding this comment.
How about something simpler here like if [[ $ORIGIN_URL != *"elastic/rally"* ]]?
There was a problem hiding this comment.
Thanks for the suggestion. I've pushed this change in ae88a21.
|
Thank you both for the reviews! :) |
novosibman
pushed a commit
to novosibman/rally
that referenced
this pull request
Oct 2, 2019
* Check that origin points to main repo for release With this commit we add a new pre-release check that ensures that the git remote named `origin` points to Rally's main repository instead of a fork. This is necessary for releases because later during the release process, changes will be pushed automatically to the main repository (such as the release tags). Relates elastic#762 Closes elastic#717
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we add a new pre-release check that ensures that the
git remote named
originpoints to Rally's main repository instead of afork. This is necessary for releases because later during the release
process, changes will be pushed automatically to the main repository
(such as the release tags).
Closes #717