Add download subcommand #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we add a new subcommand `download` to Rally that can be used to download a binary. This can be useful in automated workflows that still want to abstract how the download artefact is actually retrieved (this has to be handled differently for different releases).
danielmitterdorfer
added
enhancement
| s = supplier.create(cfg, sources=False, distribution=True, build=False, | ||
| challenge_root_path=challenge_root_path, car=car, plugins=plugins) | ||
| binaries = s() | ||
| console.println(json.dumps(binaries, indent=2), force=True) |
There was a problem hiding this comment.
So far the output format is always JSON and intentionally not configurable
dliappis
reviewed
Jun 6, 2019
|
Thanks for the review! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we add a new subcommand
downloadto Rally that can beused to download a binary. This can be useful in automated workflows
that still want to abstract how the download artefact is actually
retrieved (this has to be handled differently for different releases).