Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Measure execution time of bulk ingest pipeline #694

Merged
merged 1 commit into from
May 23, 2019
Merged

Measure execution time of bulk ingest pipeline #694

merged 1 commit into from
May 23, 2019

Conversation

drawlerr
Copy link
Contributor

Simple pass-through of ingest_took key to results, if present.

Closes #690.

@danielmitterdorfer danielmitterdorfer added :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc. enhancement Improves the status quo labels May 23, 2019
@danielmitterdorfer danielmitterdorfer added this to the 1.1.1 milestone May 23, 2019
danielmitterdorfer
danielmitterdorfer approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Can you please edit the PR's title so it is more descriptive? E.g. "Measure execution time of bulk ingest pipeline". We use the PR title in our release notes and this helps users understand the intent of a change.

dliappis
dliappis approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drawlerr drawlerr changed the title Add ingest_took to runner Measure execution time of bulk ingest pipeline May 23, 2019
@drawlerr drawlerr merged commit 65b3b02 into elastic:master May 23, 2019
@drawlerr drawlerr deleted the ingest-time branch May 23, 2019 13:08
@dliappis dliappis modified the milestones: 1.2.0, 1.2.1 Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

@danielmitterdorfer danielmitterdorfer danielmitterdorfer approved these changes

Assignees
No one assigned
Labels
enhancement Improves the status quo :Load Driver Changes that affect the core of the load driver such as scheduling, the measurement approach etc.
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.

Keep track of ingest_took statistic in bulk operation type.
3 participants
@drawlerr @danielmitterdorfer @dliappis