Introduce new command line parameter --track-revision #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows a user to run against an older commit of a Rally track. Fixes elastic#663
ebadyano
changed the title
Marked track.repository a non mandatory parameter.
ebadyano
changed the title
danielmitterdorfer
approved these changes
Mar 18, 2019
There was a problem hiding this comment.
Thanks @ebadyano! LGTM. Can you please address my nits (but no need for another review round) and also add labels and the milestone accordingly? Also I think the PR title should be in present tense.
esrally/rally.py
Outdated
| @@ -167,6 +167,10 @@ def positive_number(v): | |||
| track_source_group.add_argument( | |||
| "--track-path", | |||
| help="Define the path to a track.") | |||
| track_source_group.add_argument( | |||
| "--track-revision", | |||
| help="Define a specific revision in the tracks repository that Rally should use.", | |||
There was a problem hiding this comment.
nit: track repository
There was a problem hiding this comment.
@danielmitterdorfer Thank you for the review. I addressed you comments. Thanks!
docs/command_line_reference.rst
Outdated
| @@ -64,6 +64,11 @@ Examples:: | |||
|
|
|||
| Selects the track repository that Rally should use to resolve tracks. By default the ``default`` track repository is used, which is available in the Github project `rally-tracks <https://github.com/elastic/rally-tracks>`_. See the :doc:`track reference </track>` on how to add your own track repositories. ``--track-path`` and ``--track-repository`` as well as ``--track`` are mutually exclusive. | |||
|
|
|||
| ``track-revision`` | |||
| ~~~~~~~~~~~~~~~~~ | |||
There was a problem hiding this comment.
When building the docs, this produces the following warning:
``track-revision``
~~~~~~~~~~~~~~~~~
~/Projects/rally/docs/command_line_reference.rst:68: WARNING: Title underline too short.
Can you please fix the warning?
ebadyano
changed the title
ebadyano
added
:Track Management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows a user to run against an older commit of a Rally track.
Fixes #663