Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make --test-mode work with uncompressed data #536 #537

Merged
merged 1 commit into from
Jul 20, 2018
Merged

make --test-mode work with uncompressed data #536 #537

merged 1 commit into from
Jul 20, 2018

Conversation

krishkoneru
Copy link

fix for #536
minor change to use the correct variable.

make --test-mode work with uncompressed data elastic#536
21476e9 
minor change to use the correct variable.
@danielmitterdorfer
Copy link
Member

Thanks for your pull request @krishna-koneru! Can I please ask you to sign the contributor license agreement? Then we can integrate your fix.

@danielmitterdorfer danielmitterdorfer self-requested a review July 20, 2018 06:18
@danielmitterdorfer danielmitterdorfer added bug Something's wrong :Track Management New operations, changes in the track format, track download changes and the like labels Jul 20, 2018
@danielmitterdorfer danielmitterdorfer added this to the 1.0.1 milestone Jul 20, 2018
@danielmitterdorfer danielmitterdorfer added blocked This item cannot be finished because of a dependency and removed blocked This item cannot be finished because of a dependency labels Jul 20, 2018
danielmitterdorfer
danielmitterdorfer approved these changes Jul 20, 2018
View reviewed changes
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for signing it so quickly. The change looks good. Thanks for fixing. It will be included in the next maintenance release 1.0.1.

@danielmitterdorfer
Copy link
Member

As a workaround until the release is out you can compress your test corpus.

@danielmitterdorfer danielmitterdorfer merged commit 35ff833 into elastic:master Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmitterdorfer danielmitterdorfer danielmitterdorfer approved these changes

Assignees
No one assigned
Labels
bug Something's wrong :Track Management New operations, changes in the track format, track download changes and the like
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@krishkoneru @danielmitterdorfer