Don't require git #466
Merged
Don't require git #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we silence a spurious log message when git is not present and document under which circumstances it is ok *not* to have git installed. Closes elastic#339
danielmitterdorfer
added
enhancement
dliappis
approved these changes
Apr 11, 2018
docs/install.rst
Outdated
| ``git 1.9`` or better is required. Verify with ``git --version``. | ||
| Git is not required if **all** of the following conditions are met: | ||
|
|
||
| * You are using Rally only as a load generator (``--pipeline=benchmark-only``) or you are referring to Elasticsearch configurations with ``--team-path`` |
There was a problem hiding this comment.
Apologies for the pedantry; full stop will be appreciated for this sentence (we do it elsewhere).
docs/install.rst
Outdated
| Git is not required if **all** of the following conditions are met: | ||
|
|
||
| * You are using Rally only as a load generator (``--pipeline=benchmark-only``) or you are referring to Elasticsearch configurations with ``--team-path`` | ||
| * You create your own tracks and refer to them with ``--track-path`` |
There was a problem hiding this comment.
Same comment here, full stop would be appreciated.
esrally/utils/git.py
Outdated
| @@ -8,7 +8,8 @@ | |||
| def probed(f): | |||
| def probe(src, *args, **kwargs): | |||
| # Probe for -C | |||
| if not process.exit_status_as_bool(lambda: process.run_subprocess_with_logging("git -C %s --version" % src, level=logging.DEBUG)): | |||
| if not process.exit_status_as_bool(lambda: process.run_subprocess_with_logging("git -C %s --version" % src, level=logging.DEBUG), | |||
There was a problem hiding this comment.
Switch to format() for the string "git -C {} --version".format(src)?
|
LGTM, thanks for the update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we silence a spurious log message when git is not
present and document under which circumstances it is ok not to have
git installed.
Closes #339