Fix misleading error message when gradle is present but jdk9 is not #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when `esrally configure` is run, the gradle binary path is persisted to rally.ini only if jdk9 is also installed. However, when `esrally` is run in benchmark_from_source mode (e.g., no args provided), the gradle binary path in rally.ini is referenced before any jdk9 checks take place -- leading to the following message: `No value for mandatory configuration: section=build, key=gradle.bin` This commit persists the gradle binary path to rally.ini in any case, allowing existing logic around jdk9 to emit a sensible error. Fixes elastic#423
danielmitterdorfer
approved these changes
Mar 8, 2018
dliappis
approved these changes
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when
esrally configureis run, the gradle binary path ispersisted to rally.ini only if jdk9 is also installed. However, when
esrallyis run in benchmark_from_source mode (e.g., no args provided),the gradle binary path in rally.ini is referenced before any jdk9 checks
take place -- leading to the following message:
No value for mandatory configuration: section=build, key=gradle.binThis commit persists the gradle binary path to rally.ini whenever it exists,
allowing existing logic around jdk9 to emit a sensible error.
Fixes #423