Disallow to specify cluster settings in the track #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we don't honor the challenge property `cluster-settings` anymore as this is mixing multiple concerns (cluster setup and running the benchmark). Instead, we encourage users to use the `put-settings` API for dynamic cluster settings and the existing mechanism in rally-teams to inject static cluster settings. Closes elastic#915
danielmitterdorfer
added
enhancement
it/__init__.py
Outdated
| @@ -29,7 +29,7 @@ | |||
| from esrally.utils import process | |||
|
|
|||
| CONFIG_NAMES = ["in-memory-it", "es-it"] | |||
| DISTRIBUTIONS = ["5.6.16", "6.8.0", "7.6.0"] | |||
| DISTRIBUTIONS = ["6.8.0", "7.6.0"] | |||
There was a problem hiding this comment.
We're doing this here (as well) to decouple this PR from #1237 as rally-tracks still uses this feature for 5.x clusters.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we don't honor the challenge property
cluster-settingsanymore as this is mixing multiple concerns (clustersetup and running the benchmark). Instead, we encourage users to use the
put-settingsAPI for dynamic cluster settings and the existingmechanism in rally-teams to inject static cluster settings.
Closes #915