Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve responsiveness of track preparation #1140

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Improve responsiveness of track preparation #1140

merged 1 commit into from
Dec 21, 2020

Conversation

danielmitterdorfer
Copy link
Member

With this commit we offload track preparation to a background thread.
This ensures that the respective Rally actor is not blocked anymore and
can respond timely. One benefit of this change is that any log messages
that are emitted during track preparation show up in the log file close
to when they are emitted instead of at the end of track preparation.

@danielmitterdorfer
Improve responsiveness of track preparation
038d12c 
With this commit we offload track preparation to a background thread.
This ensures that the respective Rally actor is not blocked anymore and
can respond timely. One benefit of this change is that any log messages
that are emitted during track preparation show up in the log file close
to when they are emitted instead of at the end of track preparation.
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :Track Management New operations, changes in the track format, track download changes and the like labels Dec 17, 2020
@danielmitterdorfer danielmitterdorfer added this to the 2.0.3 milestone Dec 17, 2020
@danielmitterdorfer danielmitterdorfer self-assigned this Dec 17, 2020
gingerwizard
gingerwizard approved these changes Dec 18, 2020
View reviewed changes
Copy link

@gingerwizard gingerwizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm familiar with the actor system sufficiently to understand how the threading works and how we block subsequent tasks from being run until this thread completes. Code standard wise it looks good.

@danielmitterdorfer danielmitterdorfer merged commit 1872463 into elastic:master Dec 21, 2020
@danielmitterdorfer danielmitterdorfer deleted the responsive-prepare branch December 21, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gingerwizard gingerwizard gingerwizard approved these changes

Assignees

@danielmitterdorfer danielmitterdorfer

Labels
enhancement Improves the status quo :Track Management New operations, changes in the track format, track download changes and the like
Projects
None yet
Milestone
2.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmitterdorfer @gingerwizard