Modify chart generator to support Kibana 7.x dashboards #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebadyano
added
enhancement
|
This should only be merged once we upgrade our metric store to. 7.x. |
|
@danielmitterdorfer @dliappis could you please review? Thank you! |
could you fix the failing PR checks first? Thanks! |
|
Sorry, fixed the lint issues. |
ebadyano
removed
blocked
| @@ -1587,7 +1587,7 @@ def bulk_tasks(self): | |||
| task_names = [] | |||
| for task in self.track.find_challenge_or_default(self.challenge).schedule: | |||
| for sub_task in task: | |||
| if sub_task.operation.type == track.OperationType.Bulk.to_hyphenated_string(): | |||
| if track.OperationType.Bulk.to_hyphenated_string() in sub_task.operation.type: | |||
There was a problem hiding this comment.
I think this warrants at least a comment and maybe even an info message to the terminal on lenient matches.
esrally/chart_generator.py
Outdated
| @@ -1033,7 +1033,7 @@ def segment_memory(title, environment, race_config): | |||
| "seperate_axis": 1, | |||
| "split_mode": "filters", | |||
| "stacked": "none", | |||
| "filter": "environment:{} AND track:{}".format(environment, race_config.track), | |||
| "filter": "environment:{} AND track:\"{}\"".format(environment, race_config.track), | |||
There was a problem hiding this comment.
Maybe we should change the .format() invocations with f-strings in all places?
|
@elasticmachine test this please |
danielmitterdorfer
approved these changes
Feb 8, 2021
esrally/chart_generator.py
Outdated
| @@ -1484,7 +1471,7 @@ def generate_dashboard(chart_type, environment, track, charts, flavor=None): | |||
| "y": (row * height), | |||
| "w": chart_width, | |||
| "h": height, | |||
| "i": "{}".format(panelIndex) | |||
| "i": f"{panelIndex}" | |||
There was a problem hiding this comment.
A str(panelIndex) should be sufficient here.
|
@danielmitterdorfer thank you for the review! |
ebadyano
added
:internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the chart generator output to ndjson and addresses validation errors for child "query" on kibana 7.x.