Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid invalid triple quotes #1079

Merged
merged 4 commits into from
Oct 19, 2020
Merged

Avoid invalid triple quotes #1079

merged 4 commits into from
Oct 19, 2020

Conversation

hub-cap
Copy link
Contributor

@hub-cap hub-cap commented Oct 7, 2020

With this commit we reenable the pylint check C4002 which checks
whether triple quotes are properly formatted.

Relates #838

@hub-cap hub-cap added the cleanup Linter changes, reformatting, removal of unused code etc. label Oct 7, 2020
@hub-cap hub-cap added this to the 2.0.2 milestone Oct 7, 2020
@hub-cap hub-cap requested a review from dliappis October 7, 2020 20:40
@hub-cap hub-cap self-assigned this Oct 7, 2020
@hub-cap
Copy link
Contributor Author

hub-cap commented Oct 7, 2020

Im leaving this until #1078 is merged as it fails w/ an old buggy pylint and needs shiny new pylint to not have false positives

@hub-cap hub-cap marked this pull request as ready for review October 8, 2020 15:43
@hub-cap hub-cap changed the title Fix pylint C4002 Avoid invalid triple quotes Oct 12, 2020
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hub-cap
Copy link
Contributor Author

hub-cap commented Oct 19, 2020

@elasticmachine update branch

@hub-cap hub-cap merged commit ace6a92 into elastic:master Oct 19, 2020
@hub-cap hub-cap deleted the lint_C4002 branch October 19, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Linter changes, reformatting, removal of unused code etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants