Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Elasticsearch client library to 7.8 #1031

Merged
merged 2 commits into from
Aug 13, 2020
Merged

Upgrade Elasticsearch client library to 7.8 #1031

merged 2 commits into from
Aug 13, 2020

Conversation

danielmitterdorfer
Copy link
Member

With this commit we upgrade the Elasticsearch client library to version
7.8. This version also includes a completely rewritten implementation of
the async client that is now bundled with the main client (instead of a
separate library). This allowed us to remove several workaround that we
had to implement before.

Closes #1017

@danielmitterdorfer
Upgrade Elasticsearch client library to 7.8
09d1f5e 
With this commit we upgrade the Elasticsearch client library to version
7.8. This version also includes a completely rewritten implementation of
the async client that is now bundled with the main client (instead of a
separate library). This allowed us to remove several workaround that we
had to implement before.

Closes elastic#1017
@danielmitterdorfer danielmitterdorfer added enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc. labels Jul 23, 2020
@danielmitterdorfer danielmitterdorfer added this to the 2.0.1 milestone Jul 23, 2020
@danielmitterdorfer danielmitterdorfer self-assigned this Jul 23, 2020
@dliappis dliappis modified the milestones: 2.0.1, 2.0.2 Aug 4, 2020
@danielmitterdorfer
Copy link
Member Author

I did a stress test with 50.000 clients pushing data to Elasticsearch with the new implementation which worked flawlessly. I also benchmarked PMC with master against this implementation and did not spot any differences that cannot be attributed to run-to-run variation. Hence I'll mark it as ready for review.

@danielmitterdorfer danielmitterdorfer marked this pull request as ready for review August 5, 2020 10:59
dliappis
dliappis approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great to see all the simplifications coming from this

@danielmitterdorfer danielmitterdorfer merged commit 77ec10b into elastic:master Aug 13, 2020
@danielmitterdorfer danielmitterdorfer deleted the upgrade-es-78 branch August 13, 2020 09:07
@sethmlarson
Copy link
Contributor

🎉

@dliappis dliappis mentioned this pull request Aug 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

@hub-cap hub-cap Awaiting requested review from hub-cap

Assignees

@danielmitterdorfer danielmitterdorfer

Labels
enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.

Evaluate effort to upgrade to elasticsearch-py 7.7.0
3 participants
@danielmitterdorfer @sethmlarson @dliappis