Allow runners to determine throughput #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit Rally recognizes a new response metadata property `throughput` from runners. When it is present, it will be used as is for creating throughput samples. The following restrictions apply: 1. The runner must only be executed by one client. This is needed because throughput is calculated across all clients but in this case throughput samples are created without any further aggregation. 2. The runner should be rate-limited to avoid that too many throughput samples are created. When throughput is calculated, all responses are bucketed into one second buckets but when the calculation is overridden, each sample also results in one throughput sample. We also change the existing `IndicesRecovery` runner to use the new property in order to calculate throughput directly.
danielmitterdorfer
added
enhancement
|
Thank you for the change! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit Rally recognizes a new response metadata property
throughputfrom runners. When it is present, it will be used as is forcreating throughput samples. The following restrictions apply:
because throughput is calculated across all clients but in this case
throughput samples are created without any further aggregation.
samples are created. When throughput is calculated, all responses are
bucketed into one second buckets but when the calculation is overridden,
each sample also results in one throughput sample.
We also change the existing
IndicesRecoveryrunner to use the newproperty in order to calculate throughput directly.