Allow to specify a runtime-jdk during installation #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `install` subcommand sometimes requires to run so called install hooks, for example to install plugins. These are installed with Elasticsearch's `plugin` script which requires Java. Yet, if we rely on the bundled JDK and no other JDK is installed on the system, the `java` binary cannot be resolved because no runtime JDK is specified at all. With this commit we expose the command line option `--runtime-jdk` so users can provide `bundled` in the installation phase.
danielmitterdorfer
added
bug
|
@danielmitterdorfer should this be set to |
|
@hub-cap not in my opinion because we can't guarantee that as default (there are versions without a bundled JDK + there are pre 7.0.0 versions) and this is consistent with how we handle it with other subcommands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
installsubcommand sometimes requires to run so called installhooks, for example to install plugins. These are installed with
Elasticsearch's
pluginscript which requires Java. Yet, if we rely onthe bundled JDK and no other JDK is installed on the system, the
javabinary cannot be resolved because no runtime JDK is specified at all.
With this commit we expose the command line option
--runtime-jdksousers can provide
bundledin the installation phase.