Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use an ES distribution for plugins that are built separately #345

Closed
dadoonet opened this issue Nov 8, 2017 · 2 comments
Closed
Labels
:Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch enhancement Improves the status quo :Usability Makes Rally easier to use
Milestone

Comments

@dadoonet
Copy link
Member

dadoonet commented Nov 8, 2017

version: Rally 0.7.4

I'd like to use Rally to benchmark a plugin I'm writing. Note that I'm not doing any modification in elasticsearch itself.

So here is what I need:

  • Define the version I need for elasticsearch. --distribution-version=6.0.0-rc2 is the way to go
  • Define my plugin repository in rally.ini:
plugin.foo.remote.repo.url = file://path/to/foo/
plugin.foo.src.subdir = .
plugin.foo.build.task = assemble
plugin.foo.build.artifact.subdir = build/distributions
  • Launch rally with my plugin with:
esrally --revision="foo:master" --elasticsearch-plugins="foo" --distribution-version=6.0.0-rc2

this is failing with Rally 0.7.4

@danielmitterdorfer
Copy link
Member

This was an intentional decision to keep the initial implementation simpler but I agree that it would be nice to have this working.

As a workaround, you can specify the respective git tag so something along these lines should work:

esrally --revision="elasticsearch:6.0.0-rc2,foo:master" --elasticsearch-plugins="foo"

@danielmitterdorfer danielmitterdorfer added :Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch :Usability Makes Rally easier to use enhancement Improves the status quo labels Nov 8, 2017
@danielmitterdorfer danielmitterdorfer added this to the Pre 1.0 milestone Nov 8, 2017
@danielmitterdorfer danielmitterdorfer modified the milestones: Pre 1.0, 0.8.0 Nov 22, 2017
@danielmitterdorfer
Copy link
Member

With the next release, Rally will allow to install a plugin from sources into a released version of ES, e.g.:

esrally --revision="foo:12aefe3" --elasticsearch-plugins="foo" --distribution-version="6.0.0"

will fetch revision 12aefe3 of plugin "foo", build it and install it into an Elasticsearch 6.0.0 node.

@danielmitterdorfer danielmitterdorfer changed the title Skip building a tagged version if already available in distributions Allow to use an ES distribution for plugins that are built separately Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Benchmark Candidate Management Anything affecting how Rally sets up Elasticsearch enhancement Improves the status quo :Usability Makes Rally easier to use
Projects
None yet
Development

No branches or pull requests

2 participants