Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow previously deprecated usage of track properties in meta block #284

Closed
danielmitterdorfer opened this issue May 16, 2017 · 0 comments
Labels
breaking Non-backwards compatible change enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Milestone

Comments

@danielmitterdorfer
Copy link
Member

In #183, which we released with Rally 0.4.7, we deprecated usage of description, short-description and data-url in the track meta-block and we should remove this deprecation layer now.

This was valid (but deprecated) before:

{
  "meta": {
    "short-description": "60.8M POIs from PlanetOSM",
    "description": "This test indexes 60.8M documents (POIs from PlanetOSM, total 2.3 GB json) using 8 client threads and 5000 docs per bulk request against Elasticsearch",
    "data-url": "http://benchmarks.elasticsearch.org.s3.amazonaws.com/corpora/geopoint"
  }
}

Now, the only supported syntax is:

{
  "short-description": "60.8M POIs from PlanetOSM",
  "description": "This test indexes 60.8M documents (POIs from PlanetOSM, total 2.3 GB json) using 8 client threads and 5000 docs per bulk request against Elasticsearch",
  "data-url": "http://benchmarks.elasticsearch.org.s3.amazonaws.com/corpora/geopoint",
}
@danielmitterdorfer danielmitterdorfer added :misc Changes that don't affect users directly: linter fixes, test improvements, etc. breaking Non-backwards compatible change enhancement Improves the status quo labels May 16, 2017
@danielmitterdorfer danielmitterdorfer added this to the 0.5.4 milestone May 16, 2017
danielmitterdorfer added a commit to elastic/rally-tracks that referenced this issue May 16, 2017
danielmitterdorfer added a commit to elastic/rally-tracks that referenced this issue May 16, 2017
danielmitterdorfer added a commit to elastic/rally-tracks that referenced this issue May 16, 2017
danielmitterdorfer added a commit to elastic/rally-tracks that referenced this issue May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Non-backwards compatible change enhancement Improves the status quo :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Development

No branches or pull requests

1 participant