-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Nested Tracks #1086
Comments
@danielmitterdorfer id like to address this if possible. Happy to take but unclear on the requirements. Do we want to support to just one level i.e. like above or potential infinite hierarchies? The latter seems possible but i'm not sure if its practically worth the potential challenges and something we'd want to encourage. |
I wouldn't necessarily restrict the nesting level. I agree that infinite hierarchies are probably not a good idea but I am not certain whether e.g. two levels would be a good idea or not? But I think we'll see once we get more experience with the feature. |
Maybe we support infinite hierarchies in theory but restrict the recursive depth to a hidden config parameter. We can adjust or remove as we feel confident regards how this feature will be used? |
The implementation should actually be rather targeted in scope. It is sufficient to modify |
with this commit we add support for listing nested tracks in git-based track repositories. Previously, esrally list tracks would only list top-level directories in a target track repo which contained a track.json. This change causes full recursive search in the track repository, to better support the idea of "nested" track structures. Fixes #1086
Currently tracks can be nested and most functions work. This isn't by design e.g.
Consider the folder hierarchy
Most rally commands would work (including the ability to use the track) with the
track
parameter e.g.--track="observability/logging"
Some commands such as
esrally list tracks
will not.Do we want to support nested tracks? If so, where are the current deficiencies in support?
The text was updated successfully, but these errors were encountered: