Don't fail git clone is tty is not attached

Switch to `run_subprocess_with_logging` to provide some logs on
failures when executing `git clone` and not rely on an attached
tty (in case the daemon's been restarted with some automation in a
non-interactive shell).

esrally/utils/git.py

@@ -32,7 +32,7 @@ def is_working_copy(src):
 def clone(src, remote):
     io.ensure_dir(src)
     # Don't swallow subprocess output, user might need to enter credentials...
-    if process.run_subprocess("git clone %s %s" % (remote, src)):
+    if process.run_subprocess_with_logging("git clone %s %s" % (remote, src)):
         raise exceptions.SupplyError("Could not clone from [%s] to [%s]" % (remote, src))
 
 

tests/utils/git_test.py

@@ -27,23 +27,21 @@ def test_git_version_too_old(self, run_subprocess_with_logging, run_subprocess):
         run_subprocess_with_logging.assert_called_with("git -C /src --version", level=logging.DEBUG)
 
     @mock.patch("esrally.utils.io.ensure_dir")
-    @mock.patch("esrally.utils.process.run_subprocess")
-    def test_clone_successful(self, run_subprocess, ensure_dir):
-        run_subprocess.return_value = False
+    @mock.patch("esrally.utils.process.run_subprocess_with_logging")
+    def test_clone_successful(self, run_subprocess_with_logging, ensure_dir):
+        run_subprocess_with_logging.return_value = False
         src = "/src"
         remote = "http://github.com/some/project"
 
         git.clone(src, remote)
 
         ensure_dir.assert_called_with(src)
-        run_subprocess.assert_called_with("git clone http://github.com/some/project /src")
+        run_subprocess_with_logging.assert_called_with("git clone http://github.com/some/project /src")
 
     @mock.patch("esrally.utils.io.ensure_dir")
-    @mock.patch("esrally.utils.process.run_subprocess")
     @mock.patch("esrally.utils.process.run_subprocess_with_logging")
-    def test_clone_with_error(self, run_subprocess_with_logging, run_subprocess, ensure_dir):
-        run_subprocess_with_logging.return_value = 0
-        run_subprocess.return_value = True
+    def test_clone_with_error(self, run_subprocess_with_logging, ensure_dir):
+        run_subprocess_with_logging.return_value = 128
         src = "/src"
         remote = "http://github.com/some/project"
 
@@ -52,7 +50,7 @@ def test_clone_with_error(self, run_subprocess_with_logging, run_subprocess, ens
         self.assertEqual("Could not clone from [http://github.com/some/project] to [/src]", ctx.exception.args[0])
 
         ensure_dir.assert_called_with(src)
-        run_subprocess.assert_called_with("git clone http://github.com/some/project /src")
+        run_subprocess_with_logging.assert_called_with("git clone http://github.com/some/project /src")
 
     @mock.patch("esrally.utils.process.run_subprocess")
     @mock.patch("esrally.utils.process.run_subprocess_with_logging")