Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate that directory does not contain - #572

Merged
merged 2 commits into from
Jul 3, 2020
Merged

Validate that directory does not contain - #572

merged 2 commits into from
Jul 3, 2020

Commits on Jul 3, 2020

  1. Validate that directory do not contain - 

    As we try to ensure no directories contain -, we can also check for this. This adds a check.

The additional NewPackage method with assets was removed and merged into NewPackage for now. This means NewPackage is a bit more heavy but we have all the validation in place. It also means, the memory consumption to keep all packages is a bit higher. For the number of packages we have today, this should be ok.

Instead I plan a future refactoring that serves the /search endpoint only from the info of the BasePackage. So not all package information with the assets has to be kept in memory.

This removes all the - assets in the packages.
    @ruflin
    ruflin committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    0d856cd View commit details
    Browse the repository at this point in the history

  2. update generated files

    @ruflin
    ruflin committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    27bf8e2 View commit details
    Browse the repository at this point in the history