Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: add strings extensions #20

Merged
merged 1 commit into from
Feb 26, 2023
Merged

lib: add strings extensions #20

merged 1 commit into from
Feb 26, 2023

Conversation

efd6
Copy link
Collaborator

@efd6 efd6 commented Feb 23, 2023

This adds a readily wrappable functions from the standard library strings package (no functions that take func values no deprecated functions, no Clone and no functions for indexing into bytes).

In addition to these a string slicing method is provided to provide substring functionality.

Minor signature changes are required for one method due to UTF-8 validity rules in CEL.

For elastic/beats#34610

@efd6 efd6 requested review from andrewkroh and a team February 23, 2023 00:41
@efd6 efd6 self-assigned this Feb 23, 2023
@andrewkroh andrewkroh added the Team:Security-External Integrations Label for the Security External Integrations team label Feb 24, 2023
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 24c4902 into dev Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Security-External Integrations Label for the Security External Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants